Spindle Coolant Unexpected UI Behaviour

[AustinSaintAubin]

The Coolant Buttons in the Spindle widget do not behave as expected.
I have two separate cooling / chip removal systems.
One is connected to GRBL's Flood Coolant, the other is connected to the GRBL's Mist Coolant.
I am able to enable/disable them independently or have them both on, which is good, I want the ability to have both on/off/or just one on.

The issue is that the UI buttons do not reflect the state of the Flood Coolant, and Mist Coolant properly.
If I enable Flood Coolant, then also enable Mist Coolant, both show on the UI as off.
They Flood Coolant and Mist Coolant should be able to be toggled independently of each other in the UI.

[cncjs@v1.9.0-alpha.4]

[cheton]

@AustinSaintAubin

May you show me the result of your $G command?

I just traced the code at https://github.com/gnea/grbl/blob/master/grbl/report.c#L321, I guess it may report M78 when both mist and flood are on.

 report_util_gcode_modes_M();
  #ifdef ENABLE_M7
    if (gc_state.modal.coolant) { // Note: Multiple coolant states may be active at the same time.
      if (gc_state.modal.coolant & PL_COND_FLAG_COOLANT_MIST) { serial_write('7'); }
      if (gc_state.modal.coolant & PL_COND_FLAG_COOLANT_FLOOD) { serial_write('8'); }
    } else { serial_write('9'); }
  #else
    if (gc_state.modal.coolant) { serial_write('8'); }
    else { serial_write('9'); }
  #endif

[cheton]

Hi @chamnit

I uncommented ENABLE_M7 from config.h and found something strange. The $G parser state reported M78 when both M7 (Mist) and M8 (Flood) are turned on, may I ask if this is a desired behavior? Thanks.

[chamnit]

@cheton : It should say M7 M8. Thanks for letting me know. I'll fix it asap.

[cheton]

It looks great. Thank you for your prompt assistance.

gnea/grbl@8491225

[AustinSaintAubin]

Awesome!
Testing GRBL code now.

[AustinSaintAubin]

CNCjs UI still needs work, if both M7 & M8 are on UI shows only M8 is on.
But output looks good.

> $G
[GC:G0 G54 G17 G21 G90 G94 M5 M9 T0 F0 S40
ok
> M7
ok
> $G
[GC:G0 G54 G17 G21 G90 G94 M5 M7 T0 F0 S40]
ok
> M8
ok
> $G
[GC:G0 G54 G17 G21 G90 G94 M5 M7 M8 T0 F0 S40]
ok
> M9
ok
> $G
[GC:G0 G54 G17 G21 G90 G94 M5 M9 T0 F0 S40]
ok
> M8
ok
> $G
[GC:G0 G54 G17 G21 G90 G94 M5 M8 T0 F0 S40]
ok

[cheton]

Fixed in 1.9.0-alpha.5