Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for edge selection #167

Closed
6 tasks done
cneben opened this issue Oct 2, 2022 · 0 comments
Closed
6 tasks done

Add support for edge selection #167

cneben opened this issue Oct 2, 2022 · 0 comments
Assignees
@cneben
Labels
enhancement
Milestone
2.2.0

Comments

@cneben
Copy link
Owner

cneben commented Oct 2, 2022 •
edited

  • Optimize Qan.EdgeTemplate: Use dedicated file for orthoShapePath, curvedShapePath and straightShapePath and use Qt.createComponent().

  • Optimize Qan.EdgeTemplate: Use Loader or external components for edge end shapes (way too more unused shapes components are loaded for every edge).

  • Add qan::Selectable support for qan::Edge.

    • Add support for custom edge selection delegate in qan::Graph::createSelectionItem().

  • Draft a naive 'contains()' implementation for curved cubic bezier edges (using https://github.com/oysteinmyrmo/bezier/blob/master/include/bezier.h)

  • Add documentation.
cneben added a commit that referenced this issue Oct 2, 2022
@cneben
#167 Add selection support for edges. WIP.
3475a1f 
Signed-off-by: cneben <benoit@destrat.io>
cneben added a commit that referenced this issue Oct 2, 2022
@cneben
#167 Edge selection, add selection item support. WIP.
b1301c4 
Signed-off-by: cneben <benoit@destrat.io>
@cneben cneben self-assigned this Oct 2, 2022
@cneben cneben added this to the 2.2.0 milestone Oct 2, 2022
cneben added a commit that referenced this issue Oct 2, 2022
@cneben
#167 First working implementation.
7b93a08 
Signed-off-by: cneben <benoit@destrat.io>
cneben added a commit that referenced this issue Oct 2, 2022
@cneben
#167 Factorize EdgeTemplate edge delegates components.
62a40fb 
Signed-off-by: cneben <benoit@destrat.io>
cneben added a commit that referenced this issue Oct 2, 2022
@cneben
#167 Working.
897c1ee 
7% / 8%  memory optimization !
Still WIP.

Signed-off-by: cneben <benoit@destrat.io>
cneben added a commit that referenced this issue Oct 2, 2022
@cneben
#167 Polish EdgeTemplate.qml, edge selection WIP.
ba38965 
Signed-off-by: cneben <benoit@destrat.io>
cneben added a commit that referenced this issue Oct 2, 2022
@cneben
#167 Edge selection working.
750821f 
Signed-off-by: cneben <benoit@destrat.io>
cneben added a commit that referenced this issue Oct 2, 2022
@cneben
#167
499acdd 
Signed-off-by: cneben <benoit@destrat.io>
cneben added a commit that referenced this issue Oct 2, 2022
@cneben
Merge pull request #168 from cneben/f/#167-edge-selection
f5bccd0 
F/#167 edge selection
@cneben cneben closed this as completed Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cneben cneben

Labels
enhancement
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@cneben