Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove package-lock.json #209

Closed
Sancretor opened this issue Apr 7, 2021 · 0 comments · Fixed by #218 or #279
Closed

Remove package-lock.json #209

Sancretor opened this issue Apr 7, 2021 · 0 comments · Fixed by #218 or #279
Assignees
@ErwanGauduchon
Labels
done This issue was solved but not merged in master enhancement New feature or request
Milestone
4.0.0

Comments

@Sancretor
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Yarn is the tool used to generate the React frontend, so it generates a yarn.lock file.
Thus the package-lock.json file is only used by NPM, which is not the build tool we use.
It should then be removed.

Describe the solution you'd like

No package-lock.json, only a yarn.lock.
@Sancretor Sancretor added the enhancement New feature or request label Apr 7, 2021
@Sancretor Sancretor added this to the 4.0.0 milestone Apr 7, 2021
ErwanGauduchon added a commit that referenced this issue Apr 12, 2021
@ErwanGauduchon
remove npm file (#209)
2b13b86
@ErwanGauduchon ErwanGauduchon mentioned this issue Apr 12, 2021
Merged
12 tasks
@Sancretor Sancretor added the done This issue was solved but not merged in master label Apr 13, 2021
@Sancretor Sancretor linked a pull request Aug 27, 2021 that will close this issue
Remove package-lock.json #218
Merged
12 tasks
@Sancretor Sancretor mentioned this issue Aug 27, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErwanGauduchon ErwanGauduchon

Labels
done This issue was solved but not merged in master enhancement New feature or request
Projects
None yet
Milestone
4.0.0
2 participants
@Sancretor @ErwanGauduchon