Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate call to API in plugin web page initialization #213

Closed
Sancretor opened this issue Apr 12, 2021 · 0 comments · Fixed by #219 or #279
Closed

Duplicate call to API in plugin web page initialization #213

Sancretor opened this issue Apr 12, 2021 · 0 comments · Fixed by #219 or #279
Assignees
@ErwanGauduchon
Labels
bug Something isn't working done This issue was solved but not merged in master investigation This issue is being investigated
Milestone
4.0.0

Comments

@Sancretor
Copy link
Contributor

Describe the bug

When you load the plugin page in a web browser, you could see two similar GET requests.
We should have a look at that, to be sure we don't do multiple useless API requests.

To reproduce

  1. Open your web browser network screen
  2. Open the plugin web page

Expected behavior

A minimal amount of requests should be used, no more.

Screenshots & log

image
@Sancretor Sancretor added bug Something isn't working investigation This issue is being investigated labels Apr 12, 2021
@Sancretor Sancretor added this to the 4.0.0 milestone Apr 12, 2021
ErwanGauduchon added a commit that referenced this issue Apr 13, 2021
@ErwanGauduchon
fix duplicate API call (#213)
0f8184d
@ErwanGauduchon ErwanGauduchon mentioned this issue Apr 13, 2021
Merged
12 tasks
@Sancretor Sancretor linked a pull request Apr 13, 2021 that will close this issue
Fix duplicate API call in plugin webpage initialization (#213) #219
Merged
12 tasks
Sancretor added a commit that referenced this issue Apr 14, 2021
@Sancretor
Merge pull request #219 from cnescatlab/bugfix-213
b9e0c99 
Fix duplicate API call in plugin webpage initialization (#213)
@Sancretor Sancretor added the done This issue was solved but not merged in master label Apr 14, 2021
@Sancretor Sancretor mentioned this issue Aug 27, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErwanGauduchon ErwanGauduchon

Labels
bug Something isn't working done This issue was solved but not merged in master investigation This issue is being investigated
Projects
None yet
Milestone
4.0.0
2 participants
@Sancretor @ErwanGauduchon