Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of SQ internal API instead of localhost #231

Closed
Sancretor opened this issue May 3, 2021 · 0 comments · Fixed by #265 or #279
Closed

Use of SQ internal API instead of localhost #231

Sancretor opened this issue May 3, 2021 · 0 comments · Fixed by #265 or #279
Assignees
Labels
done This issue was solved but not merged in master enhancement New feature or request
Milestone

Comments

@Sancretor
Copy link
Contributor

Is your feature request related to a problem? Please describe.

As of now, the tool builds SQ API urls based on localhost but on some environments this may not work because of a particular firewall configuration or else.
If possible, we should not rely on an hardcoded address and determine dynamically the server base URL.

Describe the solution you'd like

We could use internal SonarQube API via specific components, and see if it uses "localhost" or something else.
It may be better to rely on SQ's own capability to determine how to access its own APIs.

Describe alternatives you've considered

We could also rely on SonarQube base URL directly.

@Sancretor Sancretor added the enhancement New feature or request label May 3, 2021
@Sancretor Sancretor added this to the 4.0.0 milestone May 3, 2021
@ErwanGauduchon ErwanGauduchon mentioned this issue Jul 22, 2021
13 tasks
@Sancretor Sancretor linked a pull request Aug 3, 2021 that will close this issue
13 tasks
@Sancretor Sancretor added the done This issue was solved but not merged in master label Aug 10, 2021
@Sancretor Sancretor mentioned this issue Aug 27, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done This issue was solved but not merged in master enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants