Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #265

Merged
merged 9 commits into from
Aug 10, 2021
Merged

Code refactoring #265

merged 9 commits into from
Aug 10, 2021

Conversation

ErwanGauduchon
Copy link
Contributor

@ErwanGauduchon ErwanGauduchon commented Jul 22, 2021

Proposed changes

Replace raw http calls with SonarQube Java API when the program is run from SonarQube UI (#231).
Update dependencies in pom.xml.
Update CI workflow with last SonarQube LTS.
Replace Travis CI badge in README.md with GitHub Action badge.
Fix a bug occurring in a specific case when generating the docx/md (#266).

Types of changes

What types of changes does your code introduce to this software?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Issues closed by changes

Checklist

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • SonarCloud and Travis CI tests pass with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

47.0% 47.0% Coverage
2.1% 2.1% Duplication

Copy link
Contributor

@Sancretor Sancretor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK for me, but I'd like to take some time to test it furthermore before we merge.

@Sancretor Sancretor merged commit ada1810 into dev Aug 10, 2021
@Sancretor Sancretor deleted the code-refactoring branch August 10, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants