Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI bug fixes #16

Merged
merged 3 commits into from
May 28, 2018
Merged

GUI bug fixes #16

merged 3 commits into from
May 28, 2018

Conversation

CfrancCyrille
Copy link
Contributor

@CfrancCyrille CfrancCyrille commented May 24, 2018

AT-NicolasMetivier and others added 3 commits April 23, 2018 10:46
Bug fix

#6 Plugin's CSS overrides SonarQube's CSS
cnescatlab#9 Metrics are not correctly displayed
cnescatlab#11 Errors appear in sonar-scanner log
@begarco begarco self-requested a review May 24, 2018 12:33
Copy link
Contributor

@begarco begarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted changes are not linked to marked issues.

Code seems to fix #12 #13 #10.

Pull request must be functionnally tested before being accepted.

@begarco begarco added this to the Correction by AtenoTech milestone May 25, 2018
@begarco begarco self-requested a review May 25, 2018 12:43
@begarco
Copy link
Contributor

begarco commented May 25, 2018

Reviewed 12 of 12 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


src/main/java/fr/cnes/sonarqube/plugins/icode/report/ICodeReportReader.java, line 20 at r1 (raw file):

package fr.cnes.sonarqube.plugins.icode.report;

public class ICodeReportReader {

What is the aim of this new class?


src/main/js/components/MetricsBulletChart/MetricsBulletChart.css, line 35 at r1 (raw file):

}

.MetricsBulletChart p {

OK


src/main/js/components/MetricsBulletChart/MetricsBulletChart.js, line 37 at r1 (raw file):

        return (
            <div className = "MetricsBulletChart" >
                <div className = "Container" >

OK for formatting


src/main/js/components/MetricsBulletChart/BulletGraph/BulletGraph.js, line 41 at r1 (raw file):

        return ( 
            <div className = "BulletGraph" >
                <HorizontalBulletGraph title = { this.props.title }

OK for formatting


src/main/js/components/MetricsBulletChart/BulletGraph/HorizontalBulletGraph.js, line 145 at r1 (raw file):

                    <p style = { titleStyles } > { this.props.title } </p>
                    <p style = { textLabelStyles } > { this.props.textLabel } </p>
                </div >

OK for formatting


src/main/js/components/MetricsSummary/MetricsSummary.css, line 1 at r1 (raw file):

tr.MetricsSummary,

OK


src/main/js/components/MetricsSummary/MetricsSummary.js, line 7 at r1 (raw file):

    render() {
        return (
            <tr className="MetricsSummary">

OK


src/main/js/components/MetricsSummary/MetricsSummary.jsx, line 6 at r1 (raw file):

function template() {
  return (
    <tr className="MetricsSummary">

OK


src/main/js/components/MetricsSummaryPanel/MetricsSummaryPanel.css, line 1 at r1 (raw file):

div.MetricsSummaryPanel th#empty-cell {

OK


src/main/js/components/MetricsSummaryPanel/MetricsSummaryPanel.js, line 24 at r1 (raw file):

    render() {
        return ( 

Formatting


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.css, line 1 at r1 (raw file):

div.MetricsSummaryTab .radio-tab {

OK


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 77 at r1 (raw file):

		    }
		});
		// console.log(allMetrics);

Leaving commented code is not proper, but it is tolerated for this time.


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 106 at r1 (raw file):

			}
		];	
		// console.log(res);

Leaving commented code is not proper, but it is tolerated for this time.


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 110 at r1 (raw file):

		resolve(res);
	}).catch(function(error) {
	    // console.log('No measures found: ' + error.message); 

Leaving commented code is not proper, but it is tolerated for this time.


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 125 at r1 (raw file):

		component:componentName
	}).then(function (measure_component) {
		// console.log(measure_component);

Leaving commented code is not proper, but it is tolerated for this time.


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 137 at r1 (raw file):

		    }
		});
		// console.log(allMetrics);

Leaving commented code is not proper, but it is tolerated for this time.


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 166 at r1 (raw file):

			}
		];	
		// console.log(res);

Leaving commented code is not proper, but it is tolerated for this time.


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 170 at r1 (raw file):

		resolve(res);
	}).catch(function(error) {
	    // console.log('No measures found: ' + error.message); 

Leaving commented code is not proper, but it is tolerated for this time.


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 185 at r1 (raw file):

		component:componentName
	}).then(function (measure_component) {
		// console.log(measure_component);

Leaving commented code is not proper, but it is tolerated for this time.


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 197 at r1 (raw file):

		    }
		});
		// console.log(allMetrics);

Leaving commented code is not proper, but it is tolerated for this time.


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 226 at r1 (raw file):

			}
		];	
		// console.log(res);

Leaving commented code is not proper, but it is tolerated for this time.


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 230 at r1 (raw file):

		resolve(res);
	}).catch(function(error) {
	    // console.log('No measures found: ' + error.message); 

Leaving commented code is not proper, but it is tolerated for this time.


src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 315 at r1 (raw file):

	};
	
	showF77Panel() {

OK


Comments from Reviewable

@begarco begarco removed their request for review May 25, 2018 13:33
@begarco begarco merged commit dd36c15 into cnescatlab:master May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants