-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI bug fixes #16
GUI bug fixes #16
Conversation
Bug fix #6 Plugin's CSS overrides SonarQube's CSS cnescatlab#9 Metrics are not correctly displayed cnescatlab#11 Errors appear in sonar-scanner log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 12 files at r1. src/main/java/fr/cnes/sonarqube/plugins/icode/report/ICodeReportReader.java, line 20 at r1 (raw file):
What is the aim of this new class? src/main/js/components/MetricsBulletChart/MetricsBulletChart.css, line 35 at r1 (raw file):
OK src/main/js/components/MetricsBulletChart/MetricsBulletChart.js, line 37 at r1 (raw file):
OK for formatting src/main/js/components/MetricsBulletChart/BulletGraph/BulletGraph.js, line 41 at r1 (raw file):
OK for formatting src/main/js/components/MetricsBulletChart/BulletGraph/HorizontalBulletGraph.js, line 145 at r1 (raw file):
OK for formatting src/main/js/components/MetricsSummary/MetricsSummary.css, line 1 at r1 (raw file):
OK src/main/js/components/MetricsSummary/MetricsSummary.js, line 7 at r1 (raw file):
OK src/main/js/components/MetricsSummary/MetricsSummary.jsx, line 6 at r1 (raw file):
OK src/main/js/components/MetricsSummaryPanel/MetricsSummaryPanel.css, line 1 at r1 (raw file):
OK src/main/js/components/MetricsSummaryPanel/MetricsSummaryPanel.js, line 24 at r1 (raw file):
Formatting src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.css, line 1 at r1 (raw file):
OK src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 77 at r1 (raw file):
Leaving commented code is not proper, but it is tolerated for this time. src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 106 at r1 (raw file):
Leaving commented code is not proper, but it is tolerated for this time. src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 110 at r1 (raw file):
Leaving commented code is not proper, but it is tolerated for this time. src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 125 at r1 (raw file):
Leaving commented code is not proper, but it is tolerated for this time. src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 137 at r1 (raw file):
Leaving commented code is not proper, but it is tolerated for this time. src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 166 at r1 (raw file):
Leaving commented code is not proper, but it is tolerated for this time. src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 170 at r1 (raw file):
Leaving commented code is not proper, but it is tolerated for this time. src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 185 at r1 (raw file):
Leaving commented code is not proper, but it is tolerated for this time. src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 197 at r1 (raw file):
Leaving commented code is not proper, but it is tolerated for this time. src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 226 at r1 (raw file):
Leaving commented code is not proper, but it is tolerated for this time. src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 230 at r1 (raw file):
Leaving commented code is not proper, but it is tolerated for this time. src/main/js/components/MetricsSummaryTab/MetricsSummaryTab.js, line 315 at r1 (raw file):
OK Comments from Reviewable |
Fixes
This change is