Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Examples #46

Closed
cnguy opened this issue Jan 25, 2018 · 3 comments
Closed

Update Examples #46

cnguy opened this issue Jan 25, 2018 · 3 comments
Labels
enhancement in-progress

Comments

@cnguy
Copy link
Owner

cnguy commented Jan 25, 2018 •
edited

Delete old examples, add new & better ones, dot dot dot.

Untagged old commits:
6eab42e refactor: prettier everything / clean up examples folder
e6aada4 docs (examples): Add verification example
c80a636 fix (examples): beginIndex should start at 100 since we already proce…
@cnguy
Copy link
Owner Author

cnguy commented Jul 27, 2018 •
edited

Also going to separate async/await examples from callbacks and promises (so I'll maintain 3, but it's not terrible). This should help beginners.

cnguy added a commit that referenced this issue Aug 30, 2018
@cnguy
feat (ChampionRotation): Add new /champion-rotations endpoint
938cb17 
* Also added ES5 (plain JS) example for converting free champion ID's
to their respective DDragon champion objects (contained within an array). Helps #46.
@cnguy cnguy mentioned this issue Aug 30, 2018
Open
cnguy added a commit that referenced this issue Oct 3, 2018
@cnguy
docs (Examples): Add grabbing DDragon info regarding banned champions…
edac5ac 
… of match #46
@cnguy
Copy link
Owner Author

cnguy commented Oct 12, 2018

https://discussion.developer.riotgames.com/questions/5645/totalgames-seems-incorrect.html

gonna add this impl to the examples too if it works, i would much prefer batch processing like this

@cnguy
Copy link
Owner Author

cnguy commented Dec 31, 2018

Needs more v4 examples

cnguy added a commit that referenced this issue Jan 5, 2019
@cnguy
docs (Examples): Add v4 async/await examples #46
2cd3b93
cnguy added a commit that referenced this issue Jan 5, 2019
@cnguy
docs (Examples): Add v4 ES5 examples #46
7a0e14d
@cnguy cnguy closed this as completed Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement in-progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cnguy