chore(test): move handling_spec off of the control flow (angular#5010)

cnishina · Mar 23, 2019 · 4f9e54d · 4f9e54d
1 parent 584e1e5
commit 4f9e54d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/spec/basic/handling_spec.js b/spec/basic/handling_spec.js
@@ -1,11 +1,10 @@
-
-describe('handling timeout errors', function() {
-
-  it('should call error handler on a timeout', function() {
-    browser.get('http://dummyUrl', 1).then(function() {
+describe('handling timeout errors', () => {
+  it('should call error handler on a timeout', async () => {
+    try {
+      await browser.get('http://dummyUrl', 1);
       throw 'did not handle error';
-    }, function(err) {
+    } catch (err) {
       expect(err instanceof Error).toBeTruthy();
-    });
+    }
   });
 });
diff --git a/spec/basicConf.js b/spec/basicConf.js
@@ -10,7 +10,8 @@ exports.config = {
   // Spec patterns are relative to this directory.
   specs: [
     'basic/elements_spec.js',
-    'basic/lib_spec.js'
+    'basic/lib_spec.js',
+    'basic/handling_spec.js'
   ],
 
   // Exclude patterns are relative to this directory.

diff --git a/spec/ciFullConf.js b/spec/ciFullConf.js
@@ -11,7 +11,8 @@ exports.config = {
   // TODO(selenium4): revert back to basic/*_spec.js
   specs: [
     'basic/elements_spec.js',
-    'basic/lib_spec.js'
+    'basic/lib_spec.js',
+    'basic/handling_spec.js'
   ],
 
   // Exclude patterns are relative to this directory.