v1.7.11 Changes (#491)

* Remove exception if no routes are found #489

* Remove unncessary instance creation in AnnotationUtility #488

* Check if Table is a subclass of Table in ModelScanner #486

* Check if class exists and is instaniable

* suppress phpmd cyclomatic complexity

src/Lib/Factory/SwaggerFactory.php

@@ -5,7 +5,6 @@
 
 use Cake\Routing\Router;
 use SwaggerBake\Lib\Configuration;
-use SwaggerBake\Lib\Exception\SwaggerBakeRunTimeException;
 use SwaggerBake\Lib\Model\ModelScanner;
 use SwaggerBake\Lib\Route\RouteScanner;
 use SwaggerBake\Lib\Swagger;
@@ -49,15 +48,6 @@ public function __construct(?Configuration $config = null, ?RouteScanner $routeS
      */
     public function create(): Swagger
     {
-        $routes = $this->routeScanner->getRoutes();
-
-        if (empty($routes)) {
-            throw new SwaggerBakeRunTimeException(
-                'No restful routes were found for your prefix `' . $this->config->getPrefix() . '`. ' .
-                'Try adding restful routes to your `config/routes.php`.'
-            );
-        }
-
         return new Swagger(new ModelScanner($this->routeScanner, $this->config));
     }
 }

src/Lib/Model/ModelScanner.php

@@ -6,6 +6,7 @@
 use Cake\Collection\Collection;
 use Cake\Database\Connection;
 use Cake\Datasource\ConnectionManager;
+use Cake\ORM\Table;
 use MixerApi\Core\Model\Model;
 use MixerApi\Core\Model\ModelFactory;
 use MixerApi\Core\Utility\NamespaceUtility;
@@ -50,6 +51,7 @@ public function __construct(RouteScanner $routeScanner, Configuration $config)
     /**
      * Gets an array of ModelDecorator instances
      *
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @return \SwaggerBake\Lib\Model\ModelDecorator[]
      */
     public function getModelDecorators(): array
@@ -69,6 +71,14 @@ public function getModelDecorators(): array
 
             foreach ($tables as $table) {
                 try {
+                    if (!class_exists($table)) {
+                        continue;
+                    }
+
+                    $reflectionClass = new \ReflectionClass($table);
+                    if (!$reflectionClass->isInstantiable() || !$reflectionClass->isSubclassOf(Table::class)) {
+                        continue;
+                    }
                     $model = (new ModelFactory($connection, new $table()))->create();
                 } catch (\Exception $e) {
                     continue;

src/Lib/Utility/AnnotationUtility.php

@@ -25,8 +25,7 @@ class AnnotationUtility
     public static function getClassAnnotationsFromFqns(string $namespace): array
     {
         try {
-            $instance = new $namespace();
-            $reflectionClass = new ReflectionClass(get_class($instance));
+            $reflectionClass = new ReflectionClass($namespace);
         } catch (Exception $e) {
             return [];
         }
@@ -83,8 +82,7 @@ public static function getMethodAnnotations(string $namespace, string $method):
         $return = [];
 
         try {
-            $instance = new $namespace();
-            $reflectionClass = new ReflectionClass(get_class($instance));
+            $reflectionClass = new ReflectionClass($namespace);
             $reflectedMethods = $reflectionClass->getMethods();
         } catch (Exception $e) {
             return $return;