Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

关于站内搜索的feature #106

Closed
lqs469 opened this issue Mar 22, 2018 · 10 comments
Closed

关于站内搜索的feature #106

lqs469 opened this issue Mar 22, 2018 · 10 comments

Comments

@lqs469
Copy link
Contributor

lqs469 commented Mar 22, 2018

cnode的egg公测帖子上有一个关于添加站内搜索的反馈
大家看是否要支持一下这个需求?
我的想法是分三个主要搜索选项:

  • 谷歌
  • 百度
  • 本地数据
    • 搜索用户名
    • 搜索帖子名

里面可能涉及新页面设计, 风格上当然保持和原有一致.
大家觉得怎么样?
@JacksonTian
Copy link
Member

我的建议是不要提供多个选项。

可以实现多种搜索，通过配置，指定一种。

@lqs469
Copy link
Contributor Author

lqs469 commented Mar 22, 2018

@JacksonTian 指定一种搜索方式给用户这样也不错, 那么支持一个站内搜索功能吧. 这个部分认领一下.

@lqs469 lqs469 changed the title 关于站内搜索的fetaure 关于站内搜索的feature Mar 22, 2018
@web-L
Copy link

web-L commented Mar 22, 2018

希望能提供多个选项搜索，或者只提供站内。

@JacksonTian
Copy link
Member

站内搜索其实对 DB 压力会大。通过 Google 这种外部搜索方式，其实也是挺好的。

@JacksonTian
Copy link
Member

不过我们可以实现。万一有人拿这个代码部署在内网呢，外部搜索就失效了。

@JacksonTian
Copy link
Member

我们实现三种，Google、Baidu、本地。

通过配置，展现一种。

@lqs469
Copy link
Contributor Author

lqs469 commented Mar 23, 2018

#107 add search mode: local, google, baidu.

@lqs469 lqs469 closed this as completed Mar 30, 2018
@atange
Copy link

atange commented Jul 22, 2018

@lqs469 使用本地搜索，输入中文的时候，搜不到内容
default

@lqs469
Copy link
Contributor Author

lqs469 commented Jul 23, 2018

@sonong @JacksonTian
已修复, 提PR: #135

@atange
Copy link

atange commented Jul 24, 2018

当时没注意测，我去测一下，感谢大神。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JacksonTian @lqs469 @atange @web-L