refactor tskv : Error passed up in async function #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bernie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Thank You |
|
@roseboy-liu please make a review |
roseboy-liu
reviewed
Aug 22, 2022
tskv/src/kvcore.rs
Outdated
|
|
||
| let summary = tokio::spawn(run_summary_job(summary, summary_task_receiver, summary_task_sender)); | ||
| if let Err(e) = tokio::try_join!(wal, flush, compact, summary) { | ||
| return Err(Error::Compact { reason: e.to_string()}) |
tskv/src/kvcore.rs
Outdated
| @@ -58,7 +59,7 @@ pub struct TsKv { | |||
| } | |||
|
|
|||
| impl TsKv { | |||
| pub async fn open(opt: Options, ts_family_num: u32) -> Result<Self> { | |||
| pub async fn open(opt: Options, ts_family_num: u32) -> Result<Self, Error> { | |||
There was a problem hiding this comment.
it has defined in error.rs mod 'pub type Result<T, E = Error> = std::result::Result<T, E>'
| @@ -475,3 +379,86 @@ impl TsKv { | |||
| Ok(None) | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| async fn run_wal_job(wal_opt: Arc<WalConfig>, mut receiver: UnboundedReceiver<WalTask>) -> Result<()> { | |||
There was a problem hiding this comment.
If there is no refactoring， in place to modify
There was a problem hiding this comment.
change to function, remove &self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors inside the [run_wal_job,run_flush_job,run_compact_job,run_summary_job] functions are passed up
避免以上四个函数中的错误在内部消耗而外部不可知而向上传递,并将方法改为异步函数形式,另外项目Error设计不是很优雅