-
Notifications
You must be signed in to change notification settings - Fork 319
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: add some necessary items to check before merging code
- Loading branch information
Showing
1 changed file
with
12 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,23 @@ | ||
| # Required checklist | ||
| - [ ] Sample config files updated (`config`,`meta/config` and `default config`) | ||
| - [ ] If there are user-facing changes, the documentation needs to be updated prior to approving the PR( [Link]() ) | ||
| - [ ] If there are any breaking changes to public APIs, please add the `api change` label. | ||
| - [ ] Signed [CLA](https://cla-assistant.io/cnosdb/cnosdb) (if not already signed) | ||
|
|
||
| # Which issue does this PR close? | ||
|
|
||
| <!-- | ||
| We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. | ||
| --> | ||
| [//]: # (We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For -- example `Closes #123` indicates that this PR will close issue #123.) | ||
|
|
||
| Related #. | ||
|
|
||
| # Rationale for this change | ||
|
|
||
| <!-- | ||
| Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. | ||
| Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. | ||
| --> | ||
|
|
||
| # What changes are included in this PR? | ||
|
|
||
| <!-- | ||
| There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR. | ||
| --> | ||
| [//]: # (Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. | ||
| Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.) | ||
|
|
||
| # Are there any user-facing changes? | ||
|
|
||
| <!-- | ||
| If there are user-facing changes then we may require documentation to be updated before approving the PR. | ||
| --> | ||
| [//]: # (There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR.) | ||
|
|
||
|
|
||
| <!-- | ||
| If there are any breaking changes to public APIs, please add the `api change` label. | ||
| --> |