Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: improve impletementation of the flight sql `do_put_prepared_… #1341

Merged
merged 1 commit into from
Jul 12, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions main/src/flight_sql/flight_sql_server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -932,11 +932,16 @@ where
"do_put_prepared_statement_update query: {:?}",
prepared_statement_ident
);
let _ = get_span_recorder(
let span_recorder = get_span_recorder(
request.extensions(),
"flight sql do_put_prepared_statement_update",
);
Ok(-1)
let (plan, query_machine) =
self.get_plan_and_qsm(prepared_statement_ident, span_recorder.span_ctx().cloned())?;
// execute plan
let query_result = self.execute_logical_plan(plan, query_machine).await?;
let output = query_result.result();
Ok(output.affected_rows().await)
}

/// Prepared statement is not supported,
Expand Down