Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor iterator and optimize performance #1467

Merged
merged 5 commits into from Sep 5, 2023
Merged

Refactor iterator and optimize performance #1467

merged 5 commits into from Sep 5, 2023

Conversation

ZuoTiJia
Copy link
Contributor

@ZuoTiJia ZuoTiJia commented Sep 1, 2023

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label.
  • Signed CLA (if not already signed)

Which issue does this PR close?

Related

Rationale for this change

@yukkit
Copy link
Contributor

yukkit commented Sep 1, 2023

begin benchmark

@roseboy-liu
Copy link
Contributor

https://cnosdb-admin.teleport.cnosdb.com/benchmark-hits/hits_87ef0e5.html
https://cnosdb-admin.teleport.cnosdb.com/benchmark-tsbs/tsbs_87ef0e5.html

@yukkit
Copy link
Contributor

yukkit commented Sep 1, 2023

begin benchmark

@roseboy-liu
Copy link
Contributor

https://cnosdb-admin.teleport.cnosdb.com/benchmark-hits/hits_87ef0e5.html
https://cnosdb-admin.teleport.cnosdb.com/benchmark-tsbs/tsbs_87ef0e5.html

@yukkit
Copy link
Contributor

yukkit commented Sep 1, 2023

begin benchmark

@roseboy-liu
Copy link
Contributor

https://cnosdb-admin.teleport.cnosdb.com/benchmark-hits/hits_87ef0e5.html
https://cnosdb-admin.teleport.cnosdb.com/benchmark-tsbs/tsbs_87ef0e5.html

roseboy-liu
roseboy-liu approved these changes Sep 5, 2023
View reviewed changes
tskv/src/tseries_family.rs Show resolved Hide resolved
@ZuoTiJia
refactor: change Arc<TskvTableSchema> to TskvTableSchemaRef
a627e6d
@ZuoTiJia
improve: impl Ord for DataType
bd29f23 
* refactor: improve TimeRanges method `overlap`

* open debug_assert for profile.test-ci
@ZuoTiJia
refactor: remove field scan timer
6734d46 
* remove points to record batch timer
@ZuoTiJia
refactor: Add data block reader
0f13227 
* Use peeked cache in SeriesGroupRowIterator

* Use priority queue to pick minimum timestamp
@ZuoTiJia
improve: Optimize read performance
0b7cf06 
* Utilizes L1 and L4 data characteristics to optimize read performance
@ZuoTiJia ZuoTiJia merged commit f831492 into cnosdb:main Sep 5, 2023
11 checks passed
@ZuoTiJia ZuoTiJia deleted the refactor-iterator branch September 5, 2023 11:04
@zipper-meng zipper-meng mentioned this pull request Sep 20, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roseboy-liu roseboy-liu roseboy-liu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZuoTiJia @yukkit @roseboy-liu