Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push_down_ne #1469

Merged
merged 2 commits into from Sep 1, 2023
Merged

push_down_ne #1469

merged 2 commits into from Sep 1, 2023

Conversation

guojidan
Copy link
Contributor

@guojidan guojidan commented Sep 1, 2023

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label.
  • Signed CLA (if not already signed)

Which issue does this PR close?

Related #559 .

Rationale for this change

Are there any user-facing changes?

yukkit
yukkit previously approved these changes Sep 1, 2023
@yukkit
Copy link
Contributor

yukkit commented Sep 1, 2023

It works for me, but it would be better if you can add related test cases

@guojidan
Copy link
Contributor Author

guojidan commented Sep 1, 2023

It works for me, but it would be better if you can add related test cases

ok, I add some test case for it.

@guojidan
Copy link
Contributor Author

guojidan commented Sep 1, 2023

It works for me, but it would be better if you can add related test cases

ok, I add some test case for it.

I think adding test cases for the Range:: ne function is sufficient

@yukkit yukkit merged commit 38172a8 into cnosdb:main Sep 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants