Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : restart lose data #1471

Merged
merged 1 commit into from Sep 27, 2023
Merged

fix : restart lose data #1471

merged 1 commit into from Sep 27, 2023

Conversation

Subsegment
Copy link
Contributor

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label.
  • Signed CLA (if not already signed)

Which issue does this PR close?

Related #.

Rationale for this change

Are there any user-facing changes?

@Subsegment Subsegment force-pushed the fix-restart branch 2 times, most recently from 605a287 to f3fd4bb Compare September 4, 2023 07:21
zipper-meng
zipper-meng reviewed Sep 15, 2023
View reviewed changes
tskv/src/kvcore.rs Outdated Show resolved Hide resolved
@Subsegment Subsegment force-pushed the fix-restart branch 2 times, most recently from 56b183f to fbcd0bf Compare September 15, 2023 08:25
@Subsegment Subsegment linked an issue Sep 26, 2023 that may be closed by this pull request
[Bug] lost data when revovering from wal #1464
Closed
zipper-meng
zipper-meng approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@zipper-meng zipper-meng left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fixed two problem:

  1. Unordered WAL read task made data lost, now parallels are grouped by VnodeId.
  2. Recovering WAL entry DeleteTable often delete data more than we expected, now each paralleled task run this deletion of it's own data.

@Subsegment Subsegment merged commit 7a082f2 into cnosdb:main Sep 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zipper-meng zipper-meng zipper-meng approved these changes

@roseboy-liu roseboy-liu Awaiting requested review from roseboy-liu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] lost data when revovering from wal
2 participants
@Subsegment @zipper-meng