Refactor cache #1560
Merged
Refactor cache #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
begin benchmark |
ZuoTiJia
force-pushed
the
refactor-cache
branch
from
09dc793
to
b8d7727
Compare
|
begin benchmark |
ZuoTiJia
force-pushed
the
refactor-cache
branch
from
b8d7727
to
62409e8
Compare
|
begin benchmark |
ZuoTiJia
force-pushed
the
refactor-cache
branch
from
62409e8
to
1e9150c
Compare
ZuoTiJia
requested review from
zipper-meng,
roseboy-liu and
Subsegment
and removed request for
zipper-meng and
roseboy-liu
ZuoTiJia
force-pushed
the
refactor-cache
branch
2 times, most recently
from
baa8fce
to
6fb1132
Compare
ZuoTiJia
force-pushed
the
refactor-cache
branch
from
6fb1132
to
dce5157
Compare
roseboy-liu
reviewed
Oct 16, 2023
ZuoTiJia
force-pushed
the
refactor-cache
branch
from
dce5157
to
8e53a87
Compare
ZuoTiJia
force-pushed
the
refactor-cache
branch
from
8e53a87
to
9c6359f
Compare
* cancel version pub field * make the name clearer * add some comments
* fix lru cache bug
* add data block exclude time range method
ZuoTiJia
force-pushed
the
refactor-cache
branch
from
9c6359f
to
e4b4758
Compare
roseboy-liu
approved these changes
Oct 18, 2023
ZuoTiJia
added a commit
that referenced
this pull request
Nov 20, 2023
* minor refactor * cancel version pub field * make the name clearer * add some comments * impl cache interface * fix lru cache bug * add database factory * refactor tskv tsm index cache * add time_range exclude method * add data block exclude time range method * remove crate lru_cache * remove runtime field of struct tskv::Database * fix error ident tsf_id of struct tskv::Index * fix: remove unused field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required checklist
config,meta/configanddefault config)api changelabel.Rationale for this change
Due to the #1511, the lru_cache crate was replaced.
And using the factory pattern simplifies the creation of TseriesFamily.