Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop tenant not drop members bug(#1452) #1626

Merged
merged 5 commits into from Oct 19, 2023
Merged

fix: drop tenant not drop members bug(#1452) #1626

merged 5 commits into from Oct 19, 2023

Conversation

lutengda
Copy link
Collaborator

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label.
  • Signed CLA (if not already signed)

Which issue does this PR close?

Related #.

Rationale for this change

Are there any user-facing changes?

@yukkit
Copy link
Contributor

yukkit commented Oct 18, 2023

Try to delete all objects under the tenant at once in the drop tenant request

@lutengda lutengda merged commit 68d0a77 into cnosdb:main Oct 19, 2023
7 checks passed
@lutengda lutengda deleted the fix_member_not_delete branch November 7, 2023 10:58
ZuoTiJia pushed a commit that referenced this pull request Nov 20, 2023
@lutengda @roseboy-liu
fix: drop tenant not drop members bug(#1452) (#1626)
0fa4123 
* fix: drop tenant not drop members bug(#1452)

* ci: add test case for #1452

* refactor: move drop members and roles to meta

* refactor: be in common use drop database

(cherry picked from commit 68d0a77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkit yukkit yukkit approved these changes

@roseboy-liu roseboy-liu Awaiting requested review from roseboy-liu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lutengda @yukkit