Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor configuration file #1812

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

Kree0
Copy link
Contributor

@Kree0 Kree0 commented Dec 8, 2023

refactor: refactor configuration file
feat: add environmrnt variable override to configuration file

Now configuration priority:

  1. specified arguments
  2. environment variable
  3. specified configuration file
  4. /etc/cnosdb/cnosdb.conf
  5. $HOME/cnosdb/cnosdb.conf
  6. default configuration

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label.
  • Signed CLA (if not already signed)

Which issue does this PR close?

#1410
#1689

Rationale for this change

Are there any user-facing changes?

@Kree0 Kree0 force-pushed the config branch 3 times, most recently from 75dcebc to 0ee8c7e Compare December 8, 2023 05:50
@zipper-meng
Copy link
Member

There are some differences from #1689 about the configuration, could you please explain it on this issue, or add a comment about your design on issue #1689?

config/config.toml Outdated Show resolved Hide resolved
feat: add environmrnt variable override to configuration file
Copy link
Member

@zipper-meng zipper-meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I's Ok.

@zipper-meng zipper-meng merged commit cdecbf4 into cnosdb:main Dec 13, 2023
1 check passed
@Kree0 Kree0 deleted the config branch December 14, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants