Fix(2.3): fix some bugs and improve the delta-compaction #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zipper-meng
changed the title
…inits in pickers; delta picker hasn't reset ColumnFile::compacting if delta-files-num is lesser than the trigger; TimeRanges::add_time_range() will join (t,t1) and (t1+1,t2)
zipper-meng
force-pushed
the
feature/lts_2.3/delta_compaction_v3
branch
from
e6c7713
to
88f72d9
Compare
roseboy-liu
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required checklist
config,meta/configanddefault config)api changelabel.Which issue does this PR close?
Related #.
Rationale for this change
TimeRanges::add_time_rangeNow it merges [(t1, t2), (t2+1, t3)] into (t1, t3), at previous it won't merge them.
CompactReq::out_time_range()to fieldCompactReq::out_time_rangeTimeRange::all()when picking for normal compaction, while it has a lot of different logic in delta compaction picking.DeltaCompactionPicker::pick_compaction()It did not reset
ColumnFile::compactingwhen delta-files-num is lesser than the trigger.Are there any user-facing changes?
No.