Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(2.3): extract function update_max_ts_of_levels #2004

Merged
merged 1 commit into from Mar 5, 2024
Merged

Refactor(2.3): extract function update_max_ts_of_levels #2004

merged 1 commit into from Mar 5, 2024

Conversation

zipper-meng
Copy link
Member

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label.
  • Signed CLA (if not already signed)

Which issue does this PR close?

Related #.

Rationale for this change

  • Fix panics when one level has the time range of (t1, i64::MAX).
  • Add unit tests of function Version::update_max_ts_of_levels()

Are there any user-facing changes?

@zipper-meng
refactor(vnode_version,2.3): extract fn update_max_ts_of_levels and a…
c99bb86 
…dd unit test, fix panic when the max_ts is i64::max
@roseboy-liu roseboy-liu merged commit 7ae7db8 into cnosdb:LTS/2.3 Mar 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roseboy-liu roseboy-liu roseboy-liu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zipper-meng @roseboy-liu