Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add TSM related unit tests to improve code coverage. #2054

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

liikeuforever
Copy link
Contributor

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label.
  • Signed CLA (if not already signed)

Which issue does this PR close?

fix: series_data.add_column modifies the schema in groups, but series_data.drop_column also removes the corresponding column from rowdata.fields in groups. If we add a column in the schema update, but remove it without updating the value in the fields, it will be out of bounds.
tskv/src/memcache.rs 314-317.

unit tests:

memcache:
series_data_write_group()
series_data_columns_modify()
series_delete_by_time_ranges()
memcache_write_group()
memcache_to_chunk_group()
memcache_columns_modify()
memcache_read_series_data()
memcache_delete_by_time_ranges()

writers:
write_and_read()
write_and_read2()
write_and_read3()

data_block:
datablock_to_pages()
datablock_merge()
datablock_sort()
datablock_chunk()
datablock_fliter_by_tomb()

flush:
flush_run()

Related #.

Rationale for this change

Are there any user-facing changes?

@Subsegment Subsegment merged commit 34f98c5 into cnosdb:main Apr 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants