Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(2.3): metrics of delta_compactions; some improvements #2055

Conversation

zipper-meng
Copy link
Member

@zipper-meng zipper-meng commented Apr 8, 2024

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label.
  • Signed CLA (if not already signed)

Which issue does this PR close?

Related #.

Rationale for this change

Compaction

Add metrics for delta compactions, to enable set config storage.collect_compaction_metrics = true.

Job

Fix the concurrent compactions sometimes less than config storage.max_concurrent_compaction.

Schedule

  • Do not trigger normal compaction after delta_compaction.
  • If a vnode has fewer delta files to trigger delta_compaction, run normal compaction on the vnode.

Are there any user-facing changes?

@zipper-meng zipper-meng force-pushed the feature/lts_2.3/delta_compaction_v4_metrics branch from cd6318a to c85c887 Compare April 8, 2024 12:05
@zipper-meng zipper-meng force-pushed the feature/lts_2.3/delta_compaction_v4_metrics branch from c85c887 to e93a447 Compare April 8, 2024 12:10
@zipper-meng zipper-meng force-pushed the feature/lts_2.3/delta_compaction_v4_metrics branch from bae6507 to 5fff4e9 Compare April 9, 2024 16:01
@roseboy-liu roseboy-liu merged commit 2c416ee into cnosdb:LTS/2.3 Apr 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants