Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors caused by sequential dependencies in CI #2084

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

liikeuforever
Copy link
Contributor

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label.
  • Signed CLA (if not already signed)

Which issue does this PR close?

Related #.

Rationale for this change

The issue with http_metric was encountered when the test was converted to sqllogictest about 2 months ago. The problem is that http_metric has dependencies, but the order of executing sqllogictest in the query_server/sqllogicaltests/src/main.rs based on std::fs::read_dir depends on the operating system. While it runs stably on the local macOS environment, the CI system running on x86 architecture occasionally encounters issues.

To address this, http_metric has added the following:

--#LP_BEGIN
m0,t0=t0 f0=false,f1=0.0 0
--#LP_BEGIN

and increased the sleep time to ensure that it can run independently and pass the tests.[1]

Are there any user-facing changes?

   *http_metric.slt : add some pre op.
@Subsegment Subsegment merged commit b292f7e into cnosdb:main Apr 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants