Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query) #539: support convert filter expr to domains for TableScan #540

Merged
merged 1 commit into from
Aug 19, 2022
Merged

feat(query) #539: support convert filter expr to domains for TableScan #540

merged 1 commit into from
Aug 19, 2022

Conversation

yukkit
Copy link
Contributor

@yukkit yukkit commented Aug 17, 2022 •
edited
Loading

Which issue does this PR close?

Closes #539 .

Rationale for this change

What changes are included in this PR?

  • support 'and' expr TableScan pushdown
  • partial support 'or' expr TableScan pushdown
  • support '=' '>' '<' '<=' '>=' operators expr TableScan pushdown
  • support Neste supported expr
  • not support 'not' 'in' 'is not null' 'not null' 'between and'

Are there any user-facing changes?

no

no

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yukkit yukkit requested review from roseboy-liu, bartliu827 and zipper-meng and removed request for roseboy-liu August 17, 2022 06:22
zipper-meng
zipper-meng approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@zipper-meng zipper-meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Okay to me.

@yukkit yukkit merged commit b457c54 into cnosdb:query_db Aug 19, 2022
@yukkit yukkit linked an issue Aug 19, 2022 that may be closed by this pull request
[Feature] Translate filter expression to domain for TableScan pushsown #539
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zipper-meng zipper-meng zipper-meng approved these changes

@bartliu827 bartliu827 Awaiting requested review from bartliu827

@roseboy-liu roseboy-liu Awaiting requested review from roseboy-liu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Translate filter expression to domain for TableScan pushsown
3 participants
@yukkit @CLAassistant @zipper-meng