feat: using egg-typebox-validate for PackageController #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
reviewed
Dec 2, 2021
fengmk2
added
enhancement
xiekw2010
commented
Dec 2, 2021
| const FullPackageRule = Type.Object({ | ||
| name: Type.String(), | ||
| // Since we don't validate versions & _attachments previous, here we use Type.Any() just for object validate | ||
| versions: Type.Record(Type.String(), Type.Any()), |
There was a problem hiding this comment.
这里为什么不对 versions 和 _attachments 也写明确的 TypeBox 定义呢？
如果写了，也就是标准的 json-schema 了，对于这个 controller 里用到的代码，对于 testcase 里的非法参数，在 ctx.tValidate 的时候就被被拦截掉。不用等到下面具体代码再去拿出值来做判断，但是 test case 的 assert 是要跑到的，所以这里为了改动小一点，临时就这写 any 了。
长期来看，所有校验都可以通过 TypeBox 写的 json-schema 来做处理，不用下面代码再去拿出来做二次校验。
There was a problem hiding this comment.
嗯，先不在这里校验，里面的校验逻辑目前还没有固化，涉及很多历史 client 版本，后续我将所有 client 上报数据格式都测试之后，再来加到这里。
xiekw2010
changed the title
fengmk2
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 ts 场景下，使用 egg-typebbox-validate 来替换 egg-validate