Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support environment variable for config 🚀 #489

Merged
merged 8 commits into from Jun 11, 2023

Conversation

Zheaoli
Copy link
Contributor

@Zheaoli Zheaoli commented Jun 1, 2023

作为 #465 的实现

  1. 将一些常见配置抽出来支持环境变量
  2. 将 MYSQL 之类的已有的环境变量统一前缀为 CNPMCORE

@Zheaoli Zheaoli force-pushed the manjusaka/support-env-variable branch from f7d786b to 5b6b094 Compare June 1, 2023 12:15
@fengmk2 fengmk2 changed the title 🚀 Support environment variable for config feat: 🚀 Support environment variable for config Jun 1, 2023
@fengmk2 fengmk2 changed the title feat: 🚀 Support environment variable for config feat: Support environment variable for config 🚀 Jun 1, 2023
config/config.default.ts Outdated Show resolved Hide resolved
config/config.default.ts Outdated Show resolved Hide resolved
config/config.default.ts Outdated Show resolved Hide resolved
@Zheaoli Zheaoli requested a review from fengmk2 June 1, 2023 13:29
config/config.default.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #489 (e22619d) into master (6624a36) will decrease coverage by 0.28%.
The diff coverage is 94.52%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   97.45%   97.17%   -0.28%     
==========================================
  Files         168      174       +6     
  Lines       15691    16272     +581     
  Branches     2018     2089      +71     
==========================================
+ Hits        15291    15812     +521     
- Misses        400      460      +60     
Impacted Files Coverage Δ
config/config.default.ts 97.63% <81.81%> (-2.37%) ⬇️
app/core/entity/Token.ts 100.00% <100.00%> (ø)
app/core/service/PackageVersionFileService.ts 93.19% <100.00%> (+0.04%) ⬆️
app/core/service/TokenService.ts 100.00% <100.00%> (+1.19%) ⬆️
app/core/service/UserService.ts 95.95% <100.00%> (ø)
app/infra/NFSClientAdapter.ts 86.90% <100.00%> (-8.45%) ⬇️
app/port/UserRoleManager.ts 100.00% <100.00%> (ø)
app/port/controller/TokenController.ts 99.11% <100.00%> (-0.03%) ⬇️
app/repository/model/Token.ts 100.00% <100.00%> (ø)

... and 22 files with indirect coverage changes

@fengmk2 fengmk2 merged commit d4d7a3d into cnpm:master Jun 11, 2023
7 of 9 checks passed
fengmk2 pushed a commit that referenced this pull request Jun 11, 2023
[skip ci]

## [3.31.0](v3.30.2...v3.31.0) (2023-06-11)

### Features

* Support environment variable for config 🚀  ([#489](#489)) ([d4d7a3d](d4d7a3d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants