fix: getModuleByRange don't list all packages

cnpm · Jul 11, 2016 · 2c606ef · 2c606ef
1 parent 79ac9fb
commit 2c606ef
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/services/package.js b/services/package.js
@@ -75,7 +75,7 @@ exports.getModuleByTag = function* (name, tag) {
 };
 
 exports.getModuleByRange = function* (name, range) {
-  var rows = yield exports.listModulesByName(name);
+  var rows = yield exports.listModulesByName(name, [ 'id', 'version' ]);
   var versionMap = {};
   var versions = rows.map(function(row) {
     versionMap[row.version] = row;
@@ -85,7 +85,12 @@ exports.getModuleByRange = function* (name, range) {
   });
 
   var version = semver.maxSatisfying(versions, range);
-  return versionMap[version];
+  if (!versionMap[version]) {
+    return null;
+  }
+
+  var id = versionMap[version].id;
+  return yield exports.getModuleById(id);
 };
 
 exports.getLatestModule = function* (name) {
@@ -241,12 +246,13 @@ exports.listAllPublicModuleNames = function* () {
   });
 };
 
-exports.listModulesByName = function* (moduleName) {
+exports.listModulesByName = function* (moduleName, attributes) {
   var mods = yield Module.findAll({
     where: {
       name: moduleName
     },
-    order: [ ['id', 'DESC'] ]
+    order: [ ['id', 'DESC'] ],
+    attributes,
   });
 
   for (var mod of mods) {