Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate API #417

Merged
merged 3 commits into from Aug 7, 2014
Merged

Deprecate API #417

merged 3 commits into from Aug 7, 2014

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Aug 7, 2014

fixed #415

@fengmk2 fengmk2 changed the title Deprecate api Deprecate API Aug 7, 2014
@fengmk2
Copy link
Member Author

fengmk2 commented Aug 7, 2014

Wait for a moment, I need to add depeacted message on package info page.

@@ -454,6 +456,15 @@ SyncModuleWorker.prototype._sync = function* (name, pkg) {
readme: version.readme
});
}

if (version.deprecated && version.deprecated !== exists.package.deprecated) {
console.log(version.deprecated, exists.package.deprecated)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console

@fengmk2
Copy link
Member Author

fengmk2 commented Aug 7, 2014

All fix

dead-horse added a commit that referenced this pull request Aug 7, 2014
@dead-horse dead-horse merged commit 6e5abe4 into master Aug 7, 2014
@dead-horse dead-horse deleted the deprecate-api branch August 7, 2014 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm deprecated support
2 participants