Skip to content
This repository has been archived by the owner on Mar 27, 2022. It is now read-only.

feat: add canvas-prebuilt sync #204

Merged
merged 1 commit into from Oct 17, 2018
Merged

feat: add canvas-prebuilt sync #204

merged 1 commit into from Oct 17, 2018

Conversation

yibn2008
Copy link
Contributor

@yibn2008 yibn2008 commented Oct 16, 2018

添加 canvas-prebuilt 镜像同步


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #204 into master will increase coverage by 4.83%.
The diff coverage is 87.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   55.23%   60.06%   +4.83%     
==========================================
  Files          17       18       +1     
  Lines         554      616      +62     
  Branches       83       91       +8     
==========================================
+ Hits          306      370      +64     
+ Misses        248      246       -2
Impacted Files Coverage Δ
config/index.js 80% <ø> (ø) ⬆️
lib/utils.js 68.75% <100%> (+7.21%) ⬆️
sync/canvas-prebuilt.js 86.44% <86.44%> (ø)
sync/syncer.js 25.31% <0%> (+6.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ab9f8...e5845b7. Read the comment docs.

});

var fileParent = fullname + pkg.dirname + '/';
fileParent = fileParent.replace('//', '/');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一句是做什么的?只用替换一次么?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是从 nodegit 里 copy 出来改的, 原来是这样写, 就没有改动

@yibn2008
Copy link
Contributor Author

@dead-horse 镜像大概什么时候会部署?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants