fix: install local folder use npm pack #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
reviewed
Jul 7, 2020
| return await utils.copyInstall(filepath, options); | ||
| try { | ||
| // use npm pack to ensure npmignore/gitignore/package.files work fine | ||
| const res = await cp.exec('npm pack', { cwd: filepath }); |
There was a problem hiding this comment.
老的逻辑安装是没问题的，不过在有些场景下会比较慢。
There was a problem hiding this comment.
我们自己去实现 pack 的过滤逻辑，要读 files/.npmignore/.gitignore，还有各种默认打包进去的规则，不太靠谱，而且绝大部分的运行环境肯定有 npm 的，只要有 node 就有 npm。
|
CI 过了， @fengmk2 |
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 93.04% 93.08% +0.03%
==========================================
Files 30 30
Lines 1928 1938 +10
==========================================
+ Hits 1794 1804 +10
Misses 134 134
Continue to review full report at Codecov.
|
fengmk2
approved these changes
Jul 7, 2020
|
4.9.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前的目录中可能有 node_modules 等不需要的文件，通过 npm pack 来打包，如果没有 npm，fallback 到直接 copy