feat: upgrade node-gyp@8 to support python3 #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix #384 |
|
https://github.com/nodejs/node-gyp/blob/master/package.json#L37 @whatwewant 你有测试过 https://github.com/nodejs/node-gyp/blob/v8.4.1/package.json#L37 node-gyp 的 v8 版本吗？它支持 python3 吗？如果可以的话，npminstall 可以只发布 minor 版本。 |
|
|
fengmk2
approved these changes
Mar 20, 2022
fengmk2
force-pushed
the
bug/fix-node-gyp-python3-support
branch
from
54a7578
to
1c8b22b
Compare
|
I rebase master and try to use node-gyp@8.4.1 |
fengmk2
changed the title
This was referenced Mar 21, 2022
|
node-gyp 最新版本只支持 python3，我先 revert 这个变更，然后发一个 npminstall major 版本。 |
|
5.x 也要发个 patch 版本，最新的一次提交修复了 Node10 不兼容问题。 |
fengmk2
added a commit
that referenced
this pull request
Mar 24, 2022
This reverts commit d02fa24. #385 (comment)
fengmk2
added a commit
that referenced
this pull request
Mar 24, 2022
This reverts commit d02fa24. #385 (comment) Keep should Python2, we will release major version to support Python3
fengmk2
added a commit
that referenced
this pull request
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #384