Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npe in lockfileConvertor #465

Merged
merged 1 commit into from Sep 20, 2023
Merged

fix: npe in lockfileConvertor #465

merged 1 commit into from Sep 20, 2023

Conversation

elrrrrrrr
Copy link
Member

Add the ignoreOptionalDependencies parameter to fix the npe with optionalDeps packages during lockfile conversion.

@elrrrrrrr elrrrrrrr added the bug label Sep 20, 2023
gemwuu
gemwuu approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@gemwuu gemwuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 merged commit 1e64b30 into 6.x Sep 20, 2023
6 of 7 checks passed
@fengmk2 fengmk2 deleted the fix-convert-option branch September 20, 2023 09:22
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
8c6c289 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
@github-actions
Copy link

🎉 This PR is included in version 6.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
9b43d02 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
9fc4075 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
4de591d 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
7491c0c 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
2abf2de 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
18902dc 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
067068b 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
af24c6a 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
ecfd46c 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
7c8eb45 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
d8a5d56 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
a47820a 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 6.7.1
88f065a 
[skip ci]

## [6.7.1](v6.7.0...v6.7.1) (2023-09-20)

### Bug Fixes

* npe in lockfileConvertor ([#465](#465)) ([1e64b30](1e64b30))
@fengmk2
Copy link
Member

fengmk2 commented Sep 20, 2023

@elrrrrrrr 修复到 master?

@elrrrrrrr elrrrrrrr mentioned this pull request Sep 20, 2023
Merged
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@elrrrrrrr
fix: lockfile convert option (#466)
dee32a1 
> pick #465
fengmk2 pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
Release 7.11.1
caae2a5 
[skip ci]

## [7.11.1](v7.11.0...v7.11.1) (2023-09-20)

### Bug Fixes

* lockfile convert option ([#466](#466)) ([dee32a1](dee32a1)), closes [#465](#465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemwuu gemwuu gemwuu approved these changes

@fengmk2 fengmk2 Awaiting requested review from fengmk2

Assignees
No one assigned
Labels
bug released on @6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elrrrrrrr @fengmk2 @gemwuu