style(autok3s): remove useless code

Signed-off-by: Jason-ZW <zhenyang@rancher.com>
cnrancher · Dec 18, 2020 · 30fbc75 · 30fbc75
1 parent c2446f8
commit 30fbc75
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/pkg/providers/alibaba/alibaba.go b/pkg/providers/alibaba/alibaba.go
@@ -1254,7 +1254,7 @@ func (p *Alibaba) generateInstance(fn checkFun, ssh *types.SSH) (*types.Cluster,
 
 func (p *Alibaba) assignEIPToInstance(num int, master bool) ([]string, error) {
 	var e error
-	eipIds := []string{}
+	eipIds := make([]string, 0)
 	eips, err := p.allocateEipAddresses(num)
 	if err != nil {
 		return nil, err
@@ -1278,9 +1278,6 @@ func (p *Alibaba) assignEIPToInstance(num int, master bool) ([]string, error) {
 			}
 			return true
 		})
-		if err != nil {
-			return nil, err
-		}
 		p.logger.Debugf("[%s] associated %d eip(s) for instance(s) successfully\n", p.GetProviderName(), num)
 	}
 
@@ -1613,7 +1610,7 @@ func (p *Alibaba) configDefaultSecurityPermissions(sg *ecs.DescribeSecurityGroup
 		}
 	}
 
-	perms := []ecs.Permission{}
+	perms := make([]ecs.Permission, 0)
 
 	if !hasSSHPort {
 		perms = append(perms, ecs.Permission{

diff --git a/pkg/providers/tencent/tencent.go b/pkg/providers/tencent/tencent.go
@@ -1589,9 +1589,6 @@ func (p *Tencent) allocateEIPForInstance(num int, master bool) ([]uint64, error)
 			}
 			return true
 		})
-		if err != nil {
-			return nil, err
-		}
 		p.logger.Debugf("[%s] successfully associated %d eip(s) for instance(s)\n", p.GetProviderName(), num)
 	}