fix(autok3s): fix nil pointer dereference

Signed-off-by: Jason-ZW <zhenyang@rancher.com>
cnrancher · Oct 13, 2020 · efb10d1 · efb10d1
1 parent 5d09459
commit efb10d1
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 3 deletions.
diff --git a/cmd/create.go b/cmd/create.go
@@ -62,6 +62,10 @@ func CreateCommand() *cobra.Command {
 	}
 
 	createCmd.Run = func(cmd *cobra.Command, args []string) {
+		if cProvider == "" {
+			logrus.Fatalln("required flags(s) \"[provider]\" not set")
+		}
+
 		// must bind after dynamic provider flags loaded.
 		common.BindPFlags(cmd, cp)
 

diff --git a/cmd/delete.go b/cmd/delete.go
@@ -31,7 +31,6 @@ func init() {
 }
 
 func DeleteCommand() *cobra.Command {
-
 	pStr := common.FlagHackLookup("--provider")
 
 	if pStr != "" {
@@ -46,6 +45,10 @@ func DeleteCommand() *cobra.Command {
 	}
 
 	deleteCmd.Run = func(cmd *cobra.Command, args []string) {
+		if dProvider == "" {
+			logrus.Fatalln("required flags(s) \"[provider]\" not set")
+		}
+
 		common.BindPFlags(cmd, dp)
 
 		// read options from config.

diff --git a/cmd/join.go b/cmd/join.go
@@ -63,6 +63,10 @@ func JoinCommand() *cobra.Command {
 	}
 
 	joinCmd.Run = func(cmd *cobra.Command, args []string) {
+		if jProvider == "" {
+			logrus.Fatalln("required flags(s) \"[provider]\" not set")
+		}
+
 		// must bind after dynamic provider flags loaded.
 		common.BindPFlags(cmd, jp)
 

diff --git a/cmd/ssh.go b/cmd/ssh.go
@@ -60,6 +60,10 @@ func SSHCommand() *cobra.Command {
 	}
 
 	sshCmd.Run = func(cmd *cobra.Command, args []string) {
+		if sProvider == "" {
+			logrus.Fatalln("required flags(s) \"[provider]\" not set")
+		}
+
 		// must bind after dynamic provider flags loaded.
 		common.BindPFlags(cmd, sp)
 

diff --git a/cmd/start.go b/cmd/start.go
@@ -29,7 +29,6 @@ func init() {
 }
 
 func StartCommand() *cobra.Command {
-
 	pStr := common.FlagHackLookup("--provider")
 
 	if pStr != "" {
@@ -44,6 +43,10 @@ func StartCommand() *cobra.Command {
 	}
 
 	startCmd.Run = func(cmd *cobra.Command, args []string) {
+		if stProvider == "" {
+			logrus.Fatalln("required flags(s) \"[provider]\" not set")
+		}
+
 		common.BindPFlags(cmd, stP)
 
 		// read options from config.

diff --git a/cmd/stop.go b/cmd/stop.go
@@ -31,7 +31,6 @@ func init() {
 }
 
 func StopCommand() *cobra.Command {
-
 	pStr := common.FlagHackLookup("--provider")
 
 	if pStr != "" {
@@ -46,6 +45,10 @@ func StopCommand() *cobra.Command {
 	}
 
 	stopCmd.Run = func(cmd *cobra.Command, args []string) {
+		if spProvider == "" {
+			logrus.Fatalln("required flags(s) \"[provider]\" not set")
+		}
+
 		common.BindPFlags(cmd, spP)
 
 		// read options from config.