support docker offline install #423
Conversation
631068264
force-pushed
the
support-offline-docker
branch
from
2258e5d
to
dd7fee7
Compare
|
@JacieChao Please review my code.Thanks. |
pkg/cluster/base.go
Outdated
| Name: "docker-arg", | ||
| P: &p.DockerArg, | ||
| V: p.DockerArg, | ||
| Usage: "Parameter for docker script", |
There was a problem hiding this comment.
It's better to give an example of how to set args.
Parameters for docker install script, e.g. xxxxxx
| @@ -39,7 +39,8 @@ type Metadata struct { | |||
| InstallScript string `json:"k3s-install-script,omitempty" yaml:"k3s-install-script,omitempty"` | |||
| Mirror string `json:"k3s-install-mirror,omitempty" yaml:"k3s-install-mirror,omitempty"` | |||
| DockerMirror string `json:"dockerMirror,omitempty" yaml:"dockerMirror,omitempty"` | |||
| DockerScript string `json:"dockerScript,omitempty" yaml:"dockerScript,omitempty"` | |||
| DockerArg string `json:"docker-arg,omitempty" yaml:"docker-arg,omitempty"` | |||
There was a problem hiding this comment.
How to set multiple parameters?
Maybe there's no more than one arg for docker installation, would it be property to use StringArray instead of string?
There was a problem hiding this comment.
For example
install_docker.sh
P3=${P1}/${P2}
cmd
--docker-arg 'P1="xxxx" P2="xxxx"'There was a problem hiding this comment.
Please add the example description to dockerArg CLI usage.
There was a problem hiding this comment.
Add more description for dockerArg , please check.
631068264
force-pushed
the
support-offline-docker
branch
from
dd7fee7
to
fb632ec
Compare
|
@631068264 Please update the commit message with |
631068264
force-pushed
the
support-offline-docker
branch
from
fb632ec
to
034b952
Compare
|
Ok already been updated |
|
@631068264 Thanks for the PR! |
Support docker offline install for private cloud which can't connect network.