Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ali teaches connor a lesson in publishing #1

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

cnrstvns
Copy link
Owner

No description provided.

@cnrstvns cnrstvns merged commit 2d91ef9 into main May 11, 2023
@cnrstvns cnrstvns deleted the fix/publishing branch May 11, 2023 06:08
@alii
Copy link
Collaborator

alii commented May 11, 2023

This PR

  • implements required fields in package.json exports field to tell TypeScript how to resolve the types.
  • uses tsup for bundling instead of tsc

Before, the types were incorrect for importing as an ESM package from an ESM runtime, or importing as a CJS package from an ESM runtime. You can run pnpm pack on an older commit, and upload to https://arethetypeswrong.github.io/ to see for yourselves.

@alii
Copy link
Collaborator

alii commented Dec 28, 2023

Fwiw you can remove the copy-types build step as tsup >= 8.0.0 (at least) correctly generates the .d.cts file. See egoist/tsup#934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants