Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RM Ch04] Rewrite 4.2 #2384

Closed
wants to merge 25 commits into from
Closed

[RM Ch04] Rewrite 4.2 #2384

wants to merge 25 commits into from

Conversation

pgoyal01
Copy link
Collaborator

Fixes #2366

The rewrite is as per the changes made by @rgstori in RM Section 2.4 and discussions with the GSMA Operator Platform Group (OPG) team members.

Please note that the variations from some of the terminology used in RM Section 2.4 will be addressed separately

@pgoyal01 pgoyal01 added WIP Work in progress Kali Release Name for 1h2021 labels Apr 30, 2021
@pgoyal01 pgoyal01 added this to the Kali - M3 - Content Freeze milestone Apr 30, 2021
@pgoyal01 pgoyal01 added this to In Progress in RM via automation Apr 30, 2021
@pgoyal01 pgoyal01 changed the title [RM Ch04] Rewrite 4.2 -- Updated TOC [RM Ch04] Rewrite 4.2 Apr 30, 2021
@pgoyal01 pgoyal01 removed the WIP Work in progress label Apr 30, 2021
@pgoyal01
Copy link
Collaborator Author

@karinesevilla commented on the wiki page, "Karine: predefined workload flavours are not really used in practice and too much associated with OpenStack and not K8s. We should remove the following table. the paragraph could be replaced by best practice sizing for VNF and CNF or examples only"

Can we delete 4.2.4.1 Predefined Workload Flavours and only the header for 4.2.4.2 Parameterised/Customised Workload Flavour Sizing Syntax (leaving the 2-line para)? WOuld that work?

@karinesevilla
Copy link
Collaborator

karinesevilla commented May 3, 2021

@karinesevilla commented on the wiki page, "Karine: predefined workload flavours are not really used in practice and too much associated with OpenStack and not K8s. We should remove the following table. the paragraph could be replaced by best practice sizing for VNF and CNF or examples only"

Can we delete 4.2.4.1 Predefined Workload Flavours and only the header for 4.2.4.2 Parameterised/Customised Workload Flavour Sizing Syntax (leaving the 2-line para)? WOuld that work?

@pgoyal01 Yes, it works. I think we can keep part of the notes of tables 4-13

RM automation moved this from In Progress to Done May 3, 2021
@pgoyal01
Copy link
Collaborator Author

pgoyal01 commented May 4, 2021

@CsatariGergely stated

Also we would need more transparency when proposing changes based on discussions with other groups. For me it is still not clear how is this change is connected to the not even published documents of GSMA OPG.

@CsatariGergely in Issue #2354, the source for 3 of the items (cpu architecture, hypervisor and operating system) was pointed out. The hypervisor situation was explicitly discussed within CNTT and is mentioned in the common/chapter00.md. RA1 Section 4.2.1 mentions "different hardware platforms (x86, Power)" as we always had the intent that the CPU hardware architecture could be different -- we just didn't list i in the capabilities. Operating System variations, is again a very obvious oversight.

SMT is listed in the diagrams but somehow is missing from the capability tables.

affinity, non-affinity are important workload placement capabilities that we somehow missed; as did OPG. We have been discussing latency w.r.t many of the workloads and hence the add.

So we are missing certain capabilities that need mitigating irrespective of who pointed them out.

@petorre
Copy link
Collaborator

petorre commented May 5, 2021

Would you also like to capture somewhere vRAN requirements like for real time and timing accuracy? Or this comes somewhere else?

@pgoyal01
Copy link
Collaborator Author

pgoyal01 commented May 5, 2021

@pgoyal01 Add "dedicated core" - both thread assigned to the workload

@pgoyal01
Copy link
Collaborator Author

pgoyal01 commented May 5, 2021

OPG.02 "Operator Platform Technical Requirements" uses the term "Resource Flavour" to describe the profile and flavour specified by the workload. @pgoyal01 add it to workload profile section.

Added "Dedicated Cores"
Cleaned-up some terminology and used "Resource Flavours" (as per OPG.02) -- workload flavours is now strictly for resource sizing.

where the specifications enclosed within "[" and "]" are optional, and the 'extra profile specs' are needed to capture special node configurations not accounted for by the profile and profile extensions.

Examples, node configurations specified as: B, B.low-latency, H, and H.very-high-speed-network.very-low-latency-edge.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgoyal01
As mentioned just before, Basic profile is for workload that can tolerate variable latency. The example B.low-latency is not consistent.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karinesevilla I tried to conform to the content in RM 2.4.2 as they were already approved and merged.

Could we have the situation where an application can request "low latency" to be placed in a site closer to the user but where this latency is not guaranteed. The application would be designed to handle "longer" latency times.


Profile Extensions represent small deviations from or further qualification of the profiles that do not require partitioning the infrastructure into separate pools, but that have specifications with a finer granularity of the profile. Profile Extensions provide workloads a more granular control over what infrastructure they can run on.

| Profile Extension Name | Mnemonic | Applicable to Basic Profile | Applicable to High Performance Profile | Description | Notes |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Profile extension should apply only to High Performance profiles

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karinesevilla Could we, for example, host applications on edge sites for better user experience but there can be occasions where the experience may perform poorly?

doc/ref_model/chapters/chapter04.md Outdated Show resolved Hide resolved
Per @karinesevilla revert to use of workload flavours
@pgoyal01 pgoyal01 requested a review from a team May 6, 2021 14:45
Add Reference numbers from PR #2399  to new entries in Section 4.2.
Correct minor typs.
@pgoyal01 pgoyal01 added the On Hold Needed to wait until another PR progress. label May 11, 2021
@pgoyal01
Copy link
Collaborator Author

As per some discussion on 2021-05-11, this PR is being suspended until PR #2405 and PR #2320 have been merged.

* [RM Ch04] Update Section 4.1 capabilities

Fixes #2398 
Update Section 4.1 with missing capabilities

* [RM Ch04] Move 4.1.7 to 4.1.2.4

As per suggestion by @karinesevilla

* [RM Ch4] TYpo correction in 4.1.4.3

"secuirty" -> "security". Thanks @petorre
@pgoyal01
Copy link
Collaborator Author

PR #2320 was merged and so the content of this PR needed to take that into account and the conflicts it generated. Created PR #2450 so as to avoid conflicts.

@walterkozlowski I recommend that we abandon this PR #2384 and concentrate now on PR #2450. Thanks

RM automation moved this from In Progress to Done May 29, 2021
@walterkozlowski
Copy link
Collaborator

As decided at RM Meeting on 26 May 2021, we can close this pR as the related work is going on in PR#2450

@pgoyal01 pgoyal01 deleted the pgoyal01-RM-patch-Ch-4-2 branch May 31, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kali Release Name for 1h2021 On Hold Needed to wait until another PR progress.
Projects
RM
  
Done
Development

Successfully merging this pull request may close these issues.

[RM Ch04] Align RM 4.2 with Chapter 02 - Node & Workload Profiles
5 participants