Skip to content

Approval Process

Jump to bottom
Rabi Abdel edited this page Aug 22, 2019 · 6 revisions

Approval process

Pull Requests will be approved in two stages:

  • Stage 1 - By Chapter Leads*: The Chapter Lead need to approve your PR before it is considered to be merged with the master. this can be done through different ways:

    • Prompt Approval

      • This can be requested/hinted by you by labelling it as "minor"
      • Pull Requests that are introducing editorial fixes and/or very minor changes can be approved by chapter leads without discussion in meetings.
        • Best Effort Judgement will be made on this by the chapter lead.
        • Pull Requests approved this way can be re-opened/reversed if proved to be controversial.

    • Online Approval within 48 hours of PR creation provided that:

      • It does not conflict with CNTT principles or uses conflicting terminology.
      • It does not suggest fundamental changes or majour addition/modification.
      • All comments and questions on the pull request has been addressed.
      • It has passed the cool off period of 48 hours where there has been no active discussions or objections to approve it.
      • it is up to the Chapter lead to decide Whether to approve a PR online (if passed above criteria) or defer it to more discussion during weekly meetings.

    • Approvals during Weekly meetings:

      • For those Pull requests that require further discussion will be discussed/approved during weekly meetings.

      *In case Chapter leads create PRs themselves, then it has to be approved by the Co-Lead for that chapter (if no Co-lead exist for that particular chapter, the Master Co-Lead will need to approve it).

      ** PR Creators may ask for any additional reviewers to approve their PRs.

  • Stage 2 - During Master meetings: PRs that are approved by Chapter Leads will be approved and merged during weekly master meeting.

    • This is to make sure dependencies are spotted and addressed between chapters or between Reference Model and Reference Architecture.
    • PRs that has been approved by their Chapter leads can be approved and merged into master promptly if considered minor.
Clone this wiki locally