Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flutter_lints rules 추가 #17

Merged
merged 5 commits into from
Oct 27, 2022
Merged

feat: flutter_lints rules 추가 #17

merged 5 commits into from
Oct 27, 2022

Conversation

CheolheeLee0
Copy link
Contributor

Describe your changes

flutter lints에 여러 옵션이 있어서 필요할 것 같은 부분 추가해두었습니다!

linter:
  rules:
    avoid_print: true		// release모드에서 출력 안되게 변경
    prefer_single_quotes: true		// single quote 통일
    require_trailing_comma: true
    always_use_package_imports: true	// 절대경로 사용
    prefer_final_locals: true		// final 사용 (컴파일러 성능 향상)
    camel_case_types: true		// camel_case_types

확인해보니 require_trailing_comma 는 위젯의 뒤에 있는 컴마를 감지하지 못하고 메서드 파라미터가 길어질 때만 감지하는 것 같습니다! 링크

Fixes #16

Checklist

  • 🤔 이 프로젝트의 스타일 가이드를 따르나요?
  • 🤔 머지하기 전에 스스로 코드에 문제가 없음을 확인했나요?
  • 🤔 필요한 주석을 필요한 곳에 넣어주었나요?

Next Step Todo (optional)

Questions

  • 💬 질문 사항이에요!
  • 🤷‍♂️ 확인 받고 싶은 부분이에요!
  • 🔥 이건 꼭 확인해주세요!

@CheolheeLee0 CheolheeLee0 mentioned this pull request Oct 27, 2022
Merged
3 tasks
@okinawaa okinawaa self-requested a review October 27, 2022 04:03
@okinawaa okinawaa changed the base branch from main to feat-home-ui October 27, 2022 04:03
@okinawaa
Copy link
Member

thx for contribution😎

@okinawaa okinawaa merged commit 7a1b76d into cnu-bot:feat-home-ui Oct 27, 2022
okinawaa added a commit that referenced this pull request Oct 27, 2022
@okinawaa @CheolheeLee0
feat: search page & search detail page (#15)
0ab2d74 
* feat: home(검색) 필요한 파일 생성

* feat: search page publish

* feat: transition for route

* feat: search page 애니메이션 작업

* feat: search detail screen 바로가기 실시간 게시물 퍼블리싱 완료

* feat: search bar 까지 작업 완료 아직 데이터 페칭은 미완성

* feat: search detail screen 검색 기능 제외 구현완료

* fix: analyze 이슈 해결

* fix: 불필요한 주석석삭제

* fix: screen util radius use r

* fix: 불필요한 주석석삭제

* fix: Color 클래스 컴마

* fix: widget사이에comma

* feat: flutter_lints rules 추가 (#17)

* feat: dart-code-metrics

* fix: add comma

* fix: replace dart_code_metrics with flutter_lints

* fix: remove unnecessary rules

* feat: camel_case_types

Co-authored-by: CheolheeLee0 <78692286+CheolheeLee0@users.noreply.github.com>
@CheolheeLee0 CheolheeLee0 self-assigned this Oct 28, 2022
@CheolheeLee0 CheolheeLee0 added the enhancement New feature or request label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okinawaa okinawaa Awaiting requested review from okinawaa

Assignees

@CheolheeLee0 CheolheeLee0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: flutter_lints rules 추가
2 participants
@CheolheeLee0 @okinawaa