[소식] 페이지 API 연동 #20
Merged
[소식] 페이지 API 연동 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
okinawaa
reviewed
Nov 6, 2022
| @@ -0,0 +1 @@ | |||
| flutter pub run build_runner build --delete-conflicting-outputs | |||
There was a problem hiding this comment.
freezed 모델 수정이나 추가하고 새로 생성할 때, 명령어가 길어 까먹는 경우가 많아서 자주 쓰는 명령어이다보니 쉘스크립트로 추가해두면 어떨까 합니다!
// 쉘 스크립트 실행 방법
sh freezed.sh
There was a problem hiding this comment.
역시.. 너무좋네요 감사합니다 잘 이용하겠습니다 저도 명령어 외우기 은근어렵더라고요
Comment on lines
+30
to
+41
| Future<List<dynamic>> getList(String url, | ||
| {dynamic param, bool? refresh}) async { | ||
| final response = await dio!.get( | ||
| url, | ||
| queryParameters: param, | ||
| options: refresh == true | ||
| ? dioCacheOptions.copyWith(policy: CachePolicy.refresh).toOptions() | ||
| : null, | ||
| ); | ||
| return response.data as List<dynamic>; | ||
| } | ||
|
|
| ), | ||
| return InkWell( | ||
| onTap: () { | ||
| Get.back(); |
There was a problem hiding this comment.
Get.back() 을 사용하면 전 라우트로돌아가는것 아닌가요?
Get.toNamed("/") 이런식으로 home으로 돌아가는것은 명시하지 않아도되나요?
일단 실행시켜보니 교통에서 소식갔다가 버튼클릭해도 교통가는것이고 홈으로 돌아가서 요구사항대로 잘 작동은 하는 것 같습니다!!
There was a problem hiding this comment.
오 그렇네요! 네 명시적으로 수정했습니다~
Comment on lines
+2
to
+13
| news('새소식', 'NEWS'), | ||
| academicInformation('학사정보', 'ACADEMIC_INFO'), | ||
| cnuNews('CNU뉴스', 'CNU_NEWS'), | ||
| educationalInformation('교육정보', 'EDUCATION_INFO'), | ||
| businessGroupStartupAndEducation('사업단 창업, 교육', 'BUSINESS_GROUP_STARTUP'), | ||
| recruitmentAndInvitation('채용/초빙', 'RECRUIT_INVITATION'), | ||
| univCultureField('대학문화마당', 'UNIV_CULTURE_FIELD'), | ||
| cnuMarket('CNU장터', 'CNU_MARKET'), | ||
| jobSearch('구인', 'JOB_SEARCH'), | ||
| jobOffer('구직', 'JOB_OFFER'), | ||
| studyCompetition('스터디 및 공모전', 'STUDY_COMPETITION'), | ||
| undefined('', ''); |
There was a problem hiding this comment.
분기처리 안해도 필드 하나만 추가하면 되는 부분이 enum의 장점인 것 같습니다!
|
리뷰 수고 많으셨습니다! 감사합니다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
영상으로 확인하기
디자인 변경사항 적용
NoticeModel 필드 수정
백마광장 게시판 연동 및 테스트 완료
news('새소식', 'NEWS'),
academicInformation('학사정보', 'ACADEMIC_INFO'),
cnuNews('CNU뉴스', 'CNU_NEWS'),
educationalInformation('교육정보', 'EDUCATION_INFO'),
businessGroupStartupAndEducation('사업단 창업, 교육', 'BUSINESS_GROUP_STARTUP'),
recruitmentAndInvitation('채용/초빙', 'RECRUIT_INVITATION'),
univCultureField('대학문화마당', 'UNIV_CULTURE_FIELD'),
cnuMarket('CNU장터', 'CNU_MARKET'),
jobSearch('구인', 'JOB_SEARCH'),
jobOffer('구직', 'JOB_OFFER'),
studyCompetition('스터디 및 공모전', 'STUDY_COMPETITION'),
국제교류본부 게시판 연동 및 테스트 완료
studentRecruiting('Student Recruiting', 'STUDENT_RECRUIT'),
event('Event', 'EVENT'),
jobAndCareer('Job&Career', 'JOB_CAREER'),
formAndData('Form&Data', 'FORM_DATA'),
Fixes #18
Checklist
Next Step Todo (optional)
Questions