Removing unused interfaces and fixing writer query.

cnuernber · Aug 24, 2021 · 4b05e57 · 4b05e57
1 parent 6707faf
commit 4b05e57
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 33 deletions.
diff --git a/java/tech/v3/datatype/BooleanWriter.java b/java/tech/v3/datatype/BooleanWriter.java
diff --git a/java/tech/v3/datatype/DoubleWriter.java b/java/tech/v3/datatype/DoubleWriter.java
diff --git a/java/tech/v3/datatype/LongWriter.java b/java/tech/v3/datatype/LongWriter.java
diff --git a/java/tech/v3/datatype/ObjectWriter.java b/java/tech/v3/datatype/ObjectWriter.java
diff --git a/src/tech/v3/datatype/base.clj b/src/tech/v3/datatype/base.clj
@@ -202,7 +202,9 @@
   writing."
   [item]
   (when item
-    (dtype-proto/convertible-to-writer? item)))
+    (if (instance? Buffer item)
+      (.allowsWrite ^Buffer item)
+      (dtype-proto/convertible-to-writer? item))))
 
 
 (defn as-writer
@@ -839,7 +841,9 @@ tech.v3.tensor.integration-test> (dtype/set-value! (dtype/clone test-tens) [:all
 
 (extend-type APersistentVector
   dtype-proto/PDatatype
-  (datatype [item] :persistent-vector))
+  (datatype [item] :persistent-vector)
+  dtype-proto/PToWriter
+  (convertible-to-writer? [buf] false))
 
 (casting/add-object-datatype! :persistent-vector APersistentVector false)
 

diff --git a/test/tech/v3/datatype_test.clj b/test/tech/v3/datatype_test.clj
@@ -706,3 +706,10 @@
 
 (deftest iterator-pathway-fails-count-29
   (is (= 3 (count (dfn/+ 3 (repeat 3 3))))))
+
+
+(deftest basic-can-write-queries
+  (is (not (dtype/writer? (dtype/->reader [1 2 3] :int32))))
+  (is (not (dtype/writer? (dtype/make-reader :int32 4 idx))))
+  (is (dtype/writer? (dtype/make-container :int32 4)))
+  (is (dtype/writer? (int-array 5))))