Skip to content

Commit

Permalink
Regression caused by overeager linting.
Browse files Browse the repository at this point in the history
  • Loading branch information
cnuernber committed Dec 4, 2021
1 parent 2bf1eef commit 6a0ed17
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
4 changes: 3 additions & 1 deletion src/tech/v3/datatype/gradient.clj
Expand Up @@ -115,7 +115,9 @@ user> (dt-grad/diff1d [1 2 4])
[data & [options]]
(let [reader (dt-base/->buffer data)
op-space (casting/simple-operation-space (.elemwiseDatatype reader))
options (or options {})]
options (or options {})
n-data (.lsize reader)
addval (or (options :prepend) (options :append))]
(errors/when-not-errorf
(not (and (options :prepend) (options :append)))
"prepend and append options cannot be used simultaneously")
Expand Down
10 changes: 8 additions & 2 deletions test/tech/v3/datatype_test.clj
Expand Up @@ -7,6 +7,8 @@
[tech.v3.datatype.functional :as dfn]
[tech.v3.datatype.argops :as argops]
[tech.v3.datatype.rolling :as rolling]
[tech.v3.datatype.gradient :as dt-grad]
[tech.v3.datatype.wavelet]
[tech.v3.datatype.datetime])
(:import [java.nio FloatBuffer]
[java.util ArrayList]))
Expand Down Expand Up @@ -781,5 +783,9 @@
(deftest mean-sum-forgiveness
(let [test-data [Double/NaN 1 2]]
(is (not (Double/isNaN (dfn/sum test-data))))
(is (not (Double/isNaN (dfn/mean test-data)))))
)
(is (not (Double/isNaN (dfn/mean test-data))))))


(deftest gradient-correct
(is (= (vec (repeat 10 1.0))
(dt-grad/gradient1d (range 10)))))

0 comments on commit 6a0ed17

Please sign in to comment.