Some fixes around ensuring referenced data doesn't get cleaned up.

cnuernber · Mar 1, 2021 · 7ba29c4 · 7ba29c4
1 parent 55e0518
commit 7ba29c4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/tech/v3/datatype/ffi.clj b/src/tech/v3/datatype/ffi.clj
@@ -220,7 +220,9 @@ user> dbuf
   (->pointer [item] item)
   NativeBuffer
   (convertible-to-pointer? [item] true)
-  (->pointer [item] (Pointer. (.address item))))
+  ;;Keep a reference to the native buffer so that it doesn't get GC'd while
+  ;;this pointer is in scope.
+  (->pointer [item] (Pointer. (.address item) {:src-buffer item})))
 
 
 (defn instantiate-class

diff --git a/src/tech/v3/datatype/native_buffer.clj b/src/tech/v3/datatype/native_buffer.clj
@@ -448,7 +448,7 @@
     (NativeBuffer. address n-elems datatype endianness resource-type
                    metadata
                    cached-io
-                   parent))
+                   item))
   Counted
   (count [item] (int (dtype-proto/ecount item)))
   Indexed