Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded relative path in test/tuner.cc #40

Closed
OursDesCavernes opened this issue May 31, 2016 · 1 comment
Closed

Hard-coded relative path in test/tuner.cc #40

OursDesCavernes opened this issue May 31, 2016 · 1 comment

Comments

@OursDesCavernes
Copy link

Hello,

I'm writing a Gentoo package for CLTune: sci-libs/cltune

The Gentoo package manager (Portage) can perform unit tests automatically after build and before installation.
A hard-coded relative path at test/tuner.cc#L46 breaks the tests as it assumes that the binary is run from a subdirectory of the source root.

An option would be to pass the source or sample base path by argument and fall back to ../samples/ if omitted.

What do you think ?

@CNugteren
Copy link
Owner

You are right, that is an issue. Luckily the tuner also accepts kernels as strings instead of loading them from file: I changed this in the latest version of the development branch. It changes test coverage slightly, but passing arguments to the Catch framework is apparently also not so trivial. I believe this is the best solution for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants