Skip to content

Commit

Permalink
Merge pull request #16 from cnumr/feat/custom-gatherers-dom-informations
Browse files Browse the repository at this point in the history
Github action for issues,  clean and doc
  • Loading branch information
hrenaud committed May 13, 2024
2 parents dde35a2 + 4abfa55 commit f558de0
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 5 deletions.
1 change: 0 additions & 1 deletion .devcontainer/intel/lhci-server/Dockerfile.lhci-server
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ WORKDIR /usr/src/lhci
COPY package.json .
COPY lighthouserc.json .
COPY .npmrc .
COPY statistic-definitions.js .
COPY patches/ patches/
RUN npm install
# COPY statistic-definitions.js /usr/src/lhci/node_modules/@lhci/server/src/api/statistic-definitions.js
Expand Down
1 change: 0 additions & 1 deletion .devcontainer/silicon/lhci-server/Dockerfile.lhci-server
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ WORKDIR /usr/src/lhci
COPY package.json .
COPY lighthouserc.json .
COPY .npmrc .
COPY statistic-definitions.js .
COPY patches/ patches/
RUN npm install
# COPY statistic-definitions.js /usr/src/lhci/node_modules/@lhci/server/src/api/statistic-definitions.js
Expand Down
23 changes: 23 additions & 0 deletions .github/workflows/close-inactive-issues.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Close inactive issues
on:
schedule:
- cron: '30 1 * * *'

jobs:
close-issues:
runs-on: ubuntu-latest
permissions:
issues: write
pull-requests: write
steps:
- uses: actions/stale@v5
with:
days-before-issue-stale: 30
days-before-issue-close: 14
stale-issue-label: 'stale'
exempt-issue-labels: 'todo,in-progress'
stale-issue-message: 'This issue is stale because it has been open for 30 days with no activity.'
close-issue-message: 'This issue was closed because it has been inactive for 14 days since being marked as stale.'
days-before-pr-stale: -1
days-before-pr-close: -1
repo-token: ${{ secrets.GITHUB_TOKEN }}
8 changes: 5 additions & 3 deletions docs/guides/4-lhci-server.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ Suivre le documentations de **LHCI Server** pour l'installation.

### `IMPORTANT` Configuration pour afficher les résultats des audits EcoIndex dans les graphs

[!ref target="blank" text="Exemple d'un `LHCI Server Docker`, avec ecoindex"](https://github.com/cnumr/lighthouse-plugin-ecoindex/tree/main/.devcontainer/intel/lhci-server)

!!! warning
A faire avant d'uploader les audits EcoIndex !
!!!
Expand Down Expand Up @@ -51,13 +53,13 @@ const definitions = {

!!! warning
**Si vous utilisez Docker, cette configuration sera parfois perdue**.
Pour palier à ce problème, vous pouvez créer un script qui modifie/remplace le fichier de configuration à chaque redémarrage du conteneur.
Pour palier à ce problème, vous pouvez créer un script qui modifie/remplace le fichier de configuration à chaque redémarrage du conteneur, ou utiliser `patch-package` pour patcher le fichier de configuration (cf. [Exemple d'un `LHCI Server Docker`, avec ecoindex](https://github.com/cnumr/lighthouse-plugin-ecoindex/tree/main/.devcontainer/intel/lhci-server)).
!!!

==- `statistic-definitions.js` sans les modifications
==- `statistic-definitions.js` sans les modifications 🟠
:::code source="default.statistic-definitions.js" :::
===
==- `statistic-definitions.js` avec les modifications
==- `statistic-definitions.js` avec les modifications 🟢
:::code source="ecoindex.statistic-definitions.js" :::
===

Expand Down

0 comments on commit f558de0

Please sign in to comment.