Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation instructions need an upgrade for python3 #153

Closed
githubaf opened this issue Mar 2, 2021 · 3 comments
Closed

Installation instructions need an upgrade for python3 #153

githubaf opened this issue Mar 2, 2021 · 3 comments

Comments

@githubaf
Copy link
Contributor

githubaf commented Mar 2, 2021

I think the installation instructions should be adapted to python3?

We need to install python3 and cython3.
IMHO the commandline should now be
python3 setup.py develop --user

( I tried installation via git clone)

Is there a way to verify the correct/complete installation?

@cnvogelg
Copy link
Owner

You are right... Python3 was not stated explicitly.
Fixed with a6a8990.

To verify clean all old installs first and then install the new version. If you use the setup above you should see a link in the python package path to your git working dir.

@githubaf
Copy link
Contributor Author

I had serious trouble with my virtual machine so I could not test faster, I am sorry.

Yes, the installation instructions look better.
I looked into setup.py.
Line 57 still says:

print("please install with: pip install cython")

That should probably also become pip3?

I did the install as

git clone https://github.com/cnvogelg/amitools
sudo pip3 install cython
cd amitools
python3 setup.py develop --user

The instruction say

or if you have installed GNU make simply use:
make

(Git and Make are more familiar to me than python)
If I just enter make, I get a help output, so it seems I need to specify a make target. Which one should I use? build? bdist? install?

make <TAB> 
bdist         clean         clean_git     docker-build  docs          help          init_user     sdist         test          
build         clean_all     clean_py      docker-tox    format        init          install       show          upload

"make show" produces an error

developer@cn-vm-afritsch:~/Desktop/SelcoGit/amitools$ make show
open build/docs/html/index.html
make: open: Command not found
make: *** [Makefile:67: show] Error 127

@cnvogelg
Copy link
Owner

Fixed in 9d5c1f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants