xdftool repack creating errors on disk, read command not able to delve into directories correctly

[Leffmann]

Creating a new disk with xdftool and verifying it with xdfscan works:

~ xdftool test.adf format "test" ffs + boot install + boot show
BootBlock(0):
 dos_type:  0x444f5301 DOS1 (valid: True) is_ffs=True is_intl=False is_dircache=False
 root_blk:  880 (got 880)
 chksum:    0xe33d0e72 (got) 0xe33d0e72 (calc) -> bootable: True
 valid:     True
 boot_code: 84 bytes
~ xdfscan test.adf
           boot  ok   test.adf  

Repacking a known-good Workbench 3.1 ADF onto the disk results in errors:

~ shasum wb.adf
486ea9520e60051c20ec01329d5a0fe3bb10b4fc  wb.adf
~ xdftool -f test.adf repack wb.adf
~ xdfscan -v test.adf
      E002 boot NOK   test.adf  
@001657:ERROR:File ext block #0 of 'asl.library' (@1656) has invalid parent: got 1572 != expect 1656
@000357:ERROR:File ext block #0 of 'amigaguide.datatype' (@356) has invalid parent: got 355 != expect 356

xdftool can not successfully delve into some directories:

~ xdftool wb.adf read libs/asl.library asl + read classes/datatypes/amigaguide.datatype amg
'read classes/datatypes/amigaguide.datatype amg' FSError: Invalid File Name(9):node=,file_name=classes/datatypes/amigaguide.datatype
~ xdftool test.adf read libs/asl.library asl2 + read classes/datatypes/amigaguide.datatype amg2
'read classes/datatypes/amigaguide.datatype amg2' FSError: Invalid File Name(9):node=,file_name=classes/datatypes/amigaguide.datatype
~ cmp asl asl2

Comparing the datatype files after extracting them using an emulator shows they are also binary identical though. I couldn't tell if the errors were in xdftool alone or also in xdfscan, and weren't able to pin them down. Sorry I can't give more useful info.

[cnvogelg]

Thanks for the detailed bug report!
I could reproduce the issue and fix it...
The bug wrote wrong parent block ids into file extension blocks :/

Fix: SHA 6d35c51

Please retest...

The other issue with invalid file name errors is fixed her: SHA 45d36ae

[Leffmann]

Thanks, this seems to fix all problems! Repacking the WB 3.1 disk set now works. xdftool can recover all files, and xdfscan and DiskSalv show no errors when inspecting the disks.