Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use namespace to merge actions property into CounterStore #87

Closed
wants to merge 1 commit into from

Conversation

Markus-Ende
Copy link
Contributor

@Markus-Ende Markus-Ende commented Dec 6, 2022

Hi @GregOnNet ,

I had another idea for the problem in #85 (regarding microsoft/TypeScript#51570).

We could use a namespace to merge the actions property into the store class. In this way, from the outside it is not distinguishable from a static property.

What do you think?

@GregOnNet
Copy link
Member

Hi,

I personally like the idea.

A bit of research showed that namespaces do not seem to be on vogue any more: https://typescript-eslint.io/rules/no-namespace/

It could be confusing to developers if they use a predefined eslint configuration, that causes a lint error. 🤔

CleanShot 2022-12-06 at 21 15 33@2x

@GregOnNet GregOnNet self-assigned this Dec 6, 2022
@GregOnNet
Copy link
Member

Closing this for now, since I am unsure if Namespaces are the way to go as mentioned above.

@Markus-Ende feel free to re-open it if you have further thoughts

@GregOnNet GregOnNet closed this Dec 16, 2022
@Markus-Ende
Copy link
Contributor Author

Yes it's not very clean, but I used this approach in our current project to have as few changes as possible, hoping it turns out to be a TypeScript bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants